Update image requirement from 0.24 to 0.25

[mnmaita]

Objective

• Closes Update image requirement from 0.24 to 0.25 #12415

Solution

• Refactored code that was changed/deprecated in image 0.25.
• Please review this PR carefully since I'm just making the changes without any context or deep knowledge of the module.

[rparrett]

I think there are a few issues here:

• read_image needs a buffer sized to total_bytes (not just with that capacity)
• The code that was adding alpha back into the image data is still needed if we are returning a TextureFormat::Rgba32Float. The hdr format never has an alpha channel.

There's an .hdr file in the assets folder you can test with -- modify examples/2d/sprite.rs to load textures/spiaggia_di_mondello_1k.hdr.

[mnmaita]

I think there are a few issues here:

• read_image needs a buffer sized to total_bytes (not just with that capacity)
• The code that was adding alpha back into the image data is still needed if we are returning a TextureFormat::Rgba32Float. The hdr format never has an alpha channel.

There's an .hdr file in the assets folder you can test with -- modify examples/2d/sprite.rs to load textures/spiaggia_di_mondello_1k.hdr.

Thanks a lot for the review, I needed some guidance here. I'll take a look at these issues and push some updates later.

[mnmaita]

@rparrett I managed to make changes so the example you've provided would load that HDR image properly. Please check if what I'm doing now is correct; I'm still unsure if I'm sizing the data buffer properly.

Also, I'd appreciate some input on the error messages since I'm not convinced on how I wrote them.

[rparrett]

Nice. Looks good to me and seems to work.

[bushrat011899]

Looks good to me!