Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compile_fail_utils no longer compiles #16802

Open
BD103 opened this issue Dec 13, 2024 · 0 comments · May be fixed by #16805
Open

compile_fail_utils no longer compiles #16802

BD103 opened this issue Dec 13, 2024 · 0 comments · May be fixed by #16805
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@BD103
Copy link
Member

BD103 commented Dec 13, 2024 •
edited
Loading

compile_fail_utils is a helper crate that we use to support our UI testing infrastructure. (UI tests are how we verify that the output of macros do not change spontaneously.) compile_fail_utils is outside of the workspace, so it is not checked by default nor caught by CI. Its integration test fails to compile (the irony), which should be fixed.

The root issue is that the test imports bevy_compile_test_utils instead of compile_fail_utils. The UI tests may need to be blessed as well.
@BD103 BD103 added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! and removed S-Needs-Triage This issue needs to be labelled labels Dec 13, 2024
@BD103 BD103 linked a pull request Dec 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compile_fail compile fail BD103/bevy
1 participant
@BD103