Try #4932:

bevyengine · Jun 24, 2022 · 6589410 · 6589410
2 parents 3d68094 + 8c0be14
commit 6589410
Show file tree

Hide file tree

Showing 10 changed files with 1,065 additions and 1,524 deletions.
diff --git a/crates/bevy_mikktspace/Cargo.toml b/crates/bevy_mikktspace/Cargo.toml
@@ -2,7 +2,11 @@
 name = "bevy_mikktspace"
 version = "0.8.0-dev"
 edition = "2021"
-authors = ["Benjamin Wasty <[email protected]>", "David Harvey-Macaulay <[email protected]>", "Layl Bongers <[email protected]>"]
+authors = [
+    "Benjamin Wasty <[email protected]>",
+    "David Harvey-Macaulay <[email protected]>",
+    "Layl Bongers <[email protected]>",
+]
 description = "Mikkelsen tangent space algorithm"
 documentation = "https://docs.rs/bevy"
 homepage = "https://bevyengine.org"
@@ -12,6 +16,10 @@ keywords = ["bevy", "3D", "graphics", "algorithm", "tangent"]
 
 [dependencies]
 glam = "0.20.0"
+bitflags = "1.3.2"
+# id-arena = "2.2.1"
+# smallvec = { version = "1.6", features = ["union"] }
+ordered-float = "3.0.0"
 
 [[example]]
 name = "generate"
diff --git a/crates/bevy_mikktspace/examples/generate.rs b/crates/bevy_mikktspace/examples/generate.rs
@@ -1,5 +1,6 @@
 #![allow(clippy::bool_assert_comparison, clippy::useless_conversion)]
 
+use bevy_mikktspace::FaceKind;
 use glam::{Vec2, Vec3};
 
 pub type Face = [u32; 3];
@@ -26,8 +27,8 @@ impl bevy_mikktspace::Geometry for Mesh {
         self.faces.len()
     }
 
-    fn num_vertices_of_face(&self, _face: usize) -> usize {
-        3
+    fn num_vertices_of_face(&self, _face: usize) -> FaceKind {
+        FaceKind::Triangle
     }
 
     fn position(&self, face: usize, vert: usize) -> [f32; 3] {