New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable name "url" in my script conflicts with url.min.js #14

Open

ghost opened this issue Jul 21, 2015 · 1 comment

ghost commented Jul 21, 2015

Web Console (Firefox): "TypeError: url is not a function"
(I'm using "url2" in my script now to get it to work.)

Owner

bettiolo commented Jul 24, 2015

Currently we are using js-url to parse urls in the browser, we would need to avoid using globals:
https://github.com/bettiolo/oauth-signature-js/blob/master/src/app/oauth-signature.js#L92-L97
In the highlighted code url is global.

We could inline url parsing logic to solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment