You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SQLAlchemy 1.4 now supports Python asyncio. In order to take advantage of this, the dialect must be "asyncio-compatible". It would be great to have a version of the base Dialect that can be used for this.
Currently the APSWDialect class subclasses SQLiteDialect, which is not async. There is a SQLiteDialect_aiosqlite that could potentially be used. The goal here is not necessarily to have async operations vis a vis sqlite but rather to allow async operations when connecting to the APIs.
This might be tricky as you would want this to be an async iterator:
SQLAlchemy 1.4 now supports Python asyncio. In order to take advantage of this, the dialect must be "asyncio-compatible". It would be great to have a version of the base
Dialect
that can be used for this.A discussion for what that entails: sqlalchemy/sqlalchemy#7854.
Currently the
APSWDialect
class subclassesSQLiteDialect
, which is not async. There is aSQLiteDialect_aiosqlite
that could potentially be used. The goal here is not necessarily to have async operations vis a vis sqlite but rather to allow async operations when connecting to the APIs.This might be tricky as you would want this to be an async iterator:
shillelagh/src/shillelagh/backends/apsw/db.py
Line 221 in 97197bd
and then likewise have the
get_rows
call be an async iterator:shillelagh/src/shillelagh/backends/apsw/vt.py
Lines 439 to 441 in 97197bd
I filed this upstream though I am not 100% sure this is the right way to solve the ask: rogerbinns/apsw#325
The text was updated successfully, but these errors were encountered: