-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check dir role on da generation #1224
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,8 +13,8 @@ | |
%p Les décisions d'attribution sont en train d'être éditées, veuillez rafraichir la page dans quelques minutes. Vous pouvez commencer à remplir des coordonnées bancaires ou des PFMPs pendant ce temps. | ||
- else | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ce n'est pas mieux d'avoir la condition "current_user.director?" en faisant un "elsif" plutôt que de dupliquer la condition ? |
||
.buttons-group | ||
- if current_establishment.missing_attributive_decisions?(selected_school_year) | ||
- if current_establishment.missing_attributive_decisions?(selected_school_year) && current_user.director? | ||
= attributive_decisions_generation_form | ||
= attributive_decisions_download_button | ||
- if current_establishment.with_attributive_decisions?(selected_school_year) && current_user.director? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renommer 'with_attributive_decisions?' par 'some_attributive_decisions?' ne serait pas mieux ? |
||
= attributive_decisions_reissue_button | ||
= attributive_decisions_reissue_generation_form |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
%section.fr-accordion | ||
%h3.fr-accordion__title | ||
%button.fr-accordion__btn{"aria-controls" => "accordion-106", "aria-expanded" => "false"} | ||
Rééditer les décisions d'attribution précédemment éditées | ||
.fr-collapse#accordion-106 | ||
= form_with method: :post, url: school_year_establishment_reissue_attributive_decisions_path(selected_school_year, current_establishment) do |form| | ||
.fr-checkbox-group | ||
= form.check_box :confirmed_director, checked: current_user.confirmed_director? | ||
= form.label :confirmed_director, class: "fr-label" do | ||
= t("panels.attributive_decisions.confirm_director").html_safe | ||
.fr-text--sm.fr-mt-1w= confirmed_director_information | ||
= form.submit "Rééditer les décisions d'attribution", class: "fr-btn fr-btn--secondary" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quel est l'intérêt de garder cette condition alors qu'on l'a déjà dans la '_attributive_decisions_panel.html.haml' ?