Check dir role on da generation #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pskl
commented
Nov 19, 2024
•
pskl
commented
- check that current user is dir before re-issuing
- add reissue checkbox
- hide reissue form with accordion
tnicolas1
reviewed
Nov 21, 2024
| @@ -29,13 +29,10 @@ def attributive_decisions_download_button | |||
| ) | |||
| end | |||
|
|
|||
| def attributive_decisions_reissue_button | |||
| def attributive_decisions_reissue_generation_form | |||
| return unless current_establishment.with_attributive_decisions?(selected_school_year) | |||
There was a problem hiding this comment.
Quel est l'intérêt de garder cette condition alors qu'on l'a déjà dans la '_attributive_decisions_panel.html.haml' ?
| @@ -13,8 +13,8 @@ | |||
| %p Les décisions d'attribution sont en train d'être éditées, veuillez rafraichir la page dans quelques minutes. Vous pouvez commencer à remplir des coordonnées bancaires ou des PFMPs pendant ce temps. | |||
| - else | |||
There was a problem hiding this comment.
Ce n'est pas mieux d'avoir la condition "current_user.director?" en faisant un "elsif" plutôt que de dupliquer la condition ?
| @@ -13,8 +13,8 @@ | |||
| %p Les décisions d'attribution sont en train d'être éditées, veuillez rafraichir la page dans quelques minutes. Vous pouvez commencer à remplir des coordonnées bancaires ou des PFMPs pendant ce temps. | |||
| - else | |||
| .buttons-group | |||
| - if current_establishment.missing_attributive_decisions?(selected_school_year) | |||
| - if current_establishment.missing_attributive_decisions?(selected_school_year) && current_user.director? | |||
| = attributive_decisions_generation_form | |||
| = attributive_decisions_download_button | |||
| - if current_establishment.with_attributive_decisions?(selected_school_year) && current_user.director? | |||
There was a problem hiding this comment.
Renommer 'with_attributive_decisions?' par 'some_attributive_decisions?' ne serait pas mieux ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.