Add Greasy Fork integration #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YDX-2147483647
requested review from
lukasmasuch,
raethlein and
JanKalkan
as code owners
|
Sorry I have no idea why the CI fails and what build-pipeline does… I notice that it also fails in #72, so I guess it's not my fault? |
YDX-2147483647
commented
Mar 4, 2024
| if not project_info.homepage: | ||
| project_info.homepage = greasy_fork_info.url | ||
|
|
||
| if ( |
There was a problem hiding this comment.
Here metadata on GitHub takes precedence. This behaviour is the same as other integrations.
Question: Should Greasy Fork take precedence?
Some people maintain multiple scripts in a single repo, but all script can live in only one repo. Therefore, metadata on Greasy Fork might be more specific (and more suitable) than those on GitHub.
YDX-2147483647
added a commit
to YDX-2147483647/best-of-generator
that referenced
this pull request
Mar 4, 2024
8 tasks
YDX-2147483647
added a commit
to YDX-2147483647/best-of-generator
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Description:
Greasy Fork is a site for user scripts. This PR adds integration for
greasy_fork_id.Greasy Fork provides their data in a simple and straight forward
greasyfork.org/scripts/*.json(e.g. https://greasyfork.org/scripts/1.json) and no token is required.(I've been using it for a few months, and it always works.)
Checklist: