-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request package upgrade for Otter Grader in the EECS Hub #4495
Comments
@NSagan271 In #4496, you highlighted that otter version v4.2.1 solves the problem locally. Does that mean you recommend upgrading to v4.2.1 over v3.3.0? If yes, couple of things to consider,
|
I can try downgrading locally to 3.3.0 (probably later today) and test it. Note that #4496 is non-urgent; even if upgrading to 4.2.1 is the only solution, there's no rush to perform that upgrade. |
I advise against doing a major version upgrade (v3.x.x -> v4.x.x) in the middle of a semester. There are likely to be breaking changes. |
Thanks @chrispyles and @NSagan271 - Will scope this activity for maintenance window (after the semester end)! |
@NSagan271 Can you let us know whether you/instructional team want to upgrade otter grader to version 4.2.1 now? If yes, couple of things to consider
|
I just graduated, so it's no longer up to me (and I'm unsure who's going to be on the instructional team next semester---I think hiring is still in flux). That being said, I'd recommend upgrading to 4.2.1 if other instructors are ok with it: it does seem to fix the issue and might fix other bugs as well. I saw that datahub.berkeley.edu was going to upgrade to 4.2.0 before this semester, how did that go? |
Thanks @NSagan271 congratulations on your graduation. Who is the instructor for the class you TA'ed? Please tag them in this issue so that there is some continuity. Datahub otter upgrade went smoothly this semester. I will check whether the instructors rewrote the test case at their end. Do you know other eecs courses that use otter-grader in eecs hub? |
Thank you! The instructor was Babak Ayazifar, but he's going on sabbatical next year. The instructor next semester is Kannan Ramchandran, I can see if he has a Github. I'll also tag some future TAs once I get more information on what the instructional team will look like next semester. I can continue to be the point of contact in the meantime. I'm not sure if any other classes in the eecs hub use otter-grader. |
Sounds great. Thank you so much @NSagan271 |
@balajialg: @yousefh409 (my co-head TA from last semester) will be staying on, and he can be the new point of contact for this thread! |
Thanks @NSagan271. Appreciate it! |
Hi @balajialg, I was wondering if there were any updates on this matter? |
@yousefh409 No, we didn't make this upgrade as one of the summer courses using the EECS hub uses the current version v3.1.4 of Otter Grader. Having said that, Otter grader version 5.0.1 got released recently (https://github.com/ucbds-infra/otter-grader/tags) and the latest stable version that got recommended to use is v4.4.1. Do you want to switch to v4.4.1 for FA 23? If yes, some test cases needs to get rewritten and @sean-morris has been helping Data 8 upgrade to the latest version of otter grader. He can help you folks with this upgrade. Do you guys want to follow Data8's path and upgrade to v4.4.1 or stick to v3.3.0. |
@balajialg Do you know to what extent the test cases must be re-written (maybe @sean-morris would know as well). Trying to gauge whether it would be worth it for us. |
Just saw this! I can help with the transition to v4. I am not sure about test cases @balajialg . We will talk tomorrow |
@yousefh409 I just had a chat with @sean-morris about the version upgrade. Listing the options in a bit more detailed way below,
Pls do let us know the option you want to consider? |
@balajialg if you go to 4 you definitely need to run the conversion script. |
@balajialg Just saw this. Thank you guys for all the detailed info, I really appreciate it! I think in that case we would like to upgrade to 4.4.1 for EE120. Please let me know if there is anything else I should do to assist with the upgrade. |
@yousefh409 I think the next step is to work with @sean-morris to convert all your scripts to be compatible with version 4.4.1. He is out till mid next week - Can we prioritize doing this activity next week? |
@balajialg Yes, I will be meeting with the new TAs tomorrow so can talk to them about it. Is there something else needed other than running the script for each notebook? |
@yousefh409 My understanding is that running this script is the main activity that needs to happen! |
Ok perfect, I’ll get started on doing so, and will let Sean know if we encounter any roadblocks. thanks again for all the help! |
Sounds great @yousefh409! |
Package Name
Otter Grader
Hub details
Course Name
As per @chrispyles. Upgrading otter-grader to version 3.3.0 is required for solving problems experienced by students enrolled in EE 120 course.
Semester Details
Spring 23
Installation Deadline
None as this is an experimental change which might prevent students from experiencing the same issue.
The text was updated successfully, but these errors were encountered: