Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sparseCheckout #123

Merged
merged 4 commits into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/Config/PackageFetcher.hs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ fetcherKeys =
data GitOptions = GitOptions
{ goDeepClone :: Maybe Bool,
goFetchSubmodules :: Maybe Bool,
goLeaveDotGit :: Maybe Bool
goLeaveDotGit :: Maybe Bool,
goSparseCheckout :: Maybe [Text]
}
deriving (Eq, Generic)

Expand All @@ -60,6 +61,7 @@ gitOptionsDecoder =
<$> getFieldsOpt ["git", "deepClone"]
<*> getFieldsOpt ["git", "fetchSubmodules"]
<*> getFieldsOpt ["git", "leaveDotGit"]
<*> getFieldsOpt ["git", "sparseCheckout"]

_GitOptions :: Traversal' (NixFetcher f) GitOptions
_GitOptions f x@FetchGit {..} =
Expand All @@ -68,16 +70,18 @@ _GitOptions f x@FetchGit {..} =
& deepClone .~ fromMaybe False goDeepClone
& fetchSubmodules .~ fromMaybe False goFetchSubmodules
& leaveDotGit .~ fromMaybe False goLeaveDotGit
& sparseCheckout .~ fromMaybe [] goSparseCheckout
)
<$> f (GitOptions (Just _deepClone) (Just _fetchSubmodules) (Just _leaveDotGit))
<$> f (GitOptions (Just _deepClone) (Just _fetchSubmodules) (Just _leaveDotGit) (Just _sparseCheckout))
_GitOptions f x@FetchGitHub {..} =
( \GitOptions {..} ->
x
& deepClone .~ fromMaybe False goDeepClone
& fetchSubmodules .~ fromMaybe False goFetchSubmodules
& leaveDotGit .~ fromMaybe False goLeaveDotGit
& sparseCheckout .~ fromMaybe [] goSparseCheckout
)
<$> f (GitOptions (Just _deepClone) (Just _fetchSubmodules) (Just _leaveDotGit))
<$> f (GitOptions (Just _deepClone) (Just _fetchSubmodules) (Just _leaveDotGit) (Just _sparseCheckout))
_GitOptions _ x = pure x

--------------------------------------------------------------------------------
Expand Down
6 changes: 6 additions & 0 deletions nvfetcher_example.toml
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,9 @@ fetch.url = "https://files.yande.re/image/3fc51f6a2fb10c96b73dd0fce6ddb9c8/yande
src.manual = "latest"
# Override the name of the file in the Nix store
url.name = "wallpaper.jpg"

# To demonstrate how to use `sparseCheckout` option
[noto-fonts-cjk-sans-fix-weight]
src.manual = "Sans2.004"
fetch.github = "notofonts/noto-cjk"
git.sparseCheckout = [ "Sans/OTC" ]
14 changes: 9 additions & 5 deletions src/NvFetcher/NixExpr.hs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ nixFetcher = \case
_fetchSubmodules = toNixExpr -> fetchSubmodules,
_deepClone = toNixExpr -> deepClone,
_leaveDotGit = toNixExpr -> leaveDotGit,
_sparseCheckout = toNixExpr . map quote -> sparseCheckout,
_furl = quote -> url,
_name = nameField -> n
} ->
Expand All @@ -76,7 +77,8 @@ nixFetcher = \case
rev = $rev;
fetchSubmodules = $fetchSubmodules;
deepClone = $deepClone;
leaveDotGit = $leaveDotGit;$n
leaveDotGit = $leaveDotGit;
sparseCheckout = $sparseCheckout;$n
sha256 = $sha256;
}
|]
Expand All @@ -86,13 +88,14 @@ nixFetcher = \case
_fetchSubmodules = toNixExpr -> fetchSubmodules,
_deepClone = toNixExpr -> deepClone,
_leaveDotGit = toNixExpr -> leaveDotGit,
_sparseCheckout = toNixExpr . map quote -> sparseCheckout,
_fowner = quote -> owner,
_frepo = quote -> repo,
_name = nameField -> n
} ->
-- TODO: fix fetchFromGitHub in Nixpkgs so that deepClone and
-- leaveDotGit won't get passed to fetchzip
if (deepClone == "true") || (leaveDotGit == "true")
-- TODO: fix fetchFromGitHub in Nixpkgs so that deepClone, leaveDotGit
-- and sparseCheckout won't get passed to fetchzip
if (deepClone == "true") || (leaveDotGit == "true") || (sparseCheckout /= "[ ]")
then
[trimming|
fetchFromGitHub {
Expand All @@ -101,7 +104,8 @@ nixFetcher = \case
rev = $rev;
fetchSubmodules = $fetchSubmodules;
deepClone = $deepClone;
leaveDotGit = $leaveDotGit;$n
leaveDotGit = $leaveDotGit;
sparseCheckout = $sparseCheckout;$n
sha256 = $sha256;
}
|]
Expand Down
15 changes: 8 additions & 7 deletions src/NvFetcher/NixFetcher.hs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ runNixPrefetchUrl url unpack name = do
newtype FetchedGit = FetchedGit {sha256 :: Text}
deriving (Show, Generic, A.FromJSON)

runNixPrefetchGit :: Text -> Text -> Bool -> Bool -> Bool -> Action Checksum
runNixPrefetchGit url rev fetchSubmodules deepClone leaveDotGit = do
runNixPrefetchGit :: Text -> Text -> Bool -> Bool -> Bool -> [Text] -> Action Checksum
runNixPrefetchGit url rev fetchSubmodules deepClone leaveDotGit sparseCheckout = do
(CmdTime t, Stdout out, CmdLine c) <-
quietly $
command [EchoStderr False] "nix-prefetch-git" $
Expand All @@ -107,6 +107,7 @@ runNixPrefetchGit url rev fetchSubmodules deepClone leaveDotGit = do
<> ["--fetch-submodules" | fetchSubmodules]
<> ["--deepClone" | deepClone]
<> ["--leave-dotGit" | leaveDotGit]
<> if null sparseCheckout then [] else ["--sparse-checkout", T.unpack $ T.intercalate "\n" sparseCheckout]
putVerbose $ "Finishing running " <> c <> ", took " <> show t <> "s"
case A.eitherDecode out of
Right (FetchedGit x) -> sha256ToSri x
Expand All @@ -117,14 +118,14 @@ runNixPrefetchGit url rev fetchSubmodules deepClone leaveDotGit = do
runFetcher :: NixFetcher Fresh -> Action (NixFetcher Fetched)
runFetcher = \case
FetchGit {..} -> do
result <- runNixPrefetchGit _furl (coerce _rev) _fetchSubmodules _deepClone _leaveDotGit
result <- runNixPrefetchGit _furl (coerce _rev) _fetchSubmodules _deepClone _leaveDotGit _sparseCheckout
pure FetchGit {_sha256 = coerce result, ..}
FetchGitHub {..} -> do
let useFetchGit = _fetchSubmodules || _leaveDotGit || _deepClone
let useFetchGit = _fetchSubmodules || _leaveDotGit || _deepClone || not (null _sparseCheckout)
ver = coerce _rev
result <-
if useFetchGit
then runNixPrefetchGit [trimming|https://github.com/$_fowner/$_frepo|] (coerce _rev) _fetchSubmodules _deepClone _leaveDotGit
then runNixPrefetchGit [trimming|https://github.com/$_fowner/$_frepo|] (coerce _rev) _fetchSubmodules _deepClone _leaveDotGit _sparseCheckout
else runNixPrefetchUrl [trimming|https://github.com/$_fowner/$_frepo/archive/$ver.tar.gz|] True mempty
pure FetchGitHub {_sha256 = result, ..}
FetchUrl {..} -> do
Expand Down Expand Up @@ -186,14 +187,14 @@ prefetch f force = askOracle $ RunFetch force f

-- | Create a fetcher from git url
gitFetcher :: Text -> PackageFetcher
gitFetcher furl rev = FetchGit furl rev False True False Nothing ()
gitFetcher furl rev = FetchGit furl rev False True False [] Nothing ()

-- | Create a fetcher from github repo
gitHubFetcher ::
-- | owner and repo
(Text, Text) ->
PackageFetcher
gitHubFetcher (owner, repo) rev = FetchGitHub owner repo rev False False False Nothing ()
gitHubFetcher (owner, repo) rev = FetchGitHub owner repo rev False False False [] Nothing ()

-- | Create a fetcher from pypi
pypiFetcher :: Text -> PackageFetcher
Expand Down
10 changes: 8 additions & 2 deletions src/NvFetcher/Types.hs
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ data NixFetcher (k :: FetchStatus)
_deepClone :: Bool,
_fetchSubmodules :: Bool,
_leaveDotGit :: Bool,
_sparseCheckout :: [Text],
_name :: Maybe Text,
_sha256 :: FetchResult Checksum k
}
Expand All @@ -404,6 +405,7 @@ data NixFetcher (k :: FetchStatus)
_deepClone :: Bool,
_fetchSubmodules :: Bool,
_leaveDotGit :: Bool,
_sparseCheckout :: [Text],
_name :: Maybe Text,
_sha256 :: FetchResult Checksum k
}
Expand Down Expand Up @@ -461,6 +463,7 @@ instance A.ToJSON (NixFetcher Fetched) where
"deepClone" A..= _deepClone,
"fetchSubmodules" A..= _fetchSubmodules,
"leaveDotGit" A..= _leaveDotGit,
"sparseCheckout" A..= _sparseCheckout,
"name" A..= _name,
"sha256" A..= _sha256,
"type" A..= A.String "git"
Expand All @@ -473,6 +476,7 @@ instance A.ToJSON (NixFetcher Fetched) where
"deepClone" A..= _deepClone,
"fetchSubmodules" A..= _fetchSubmodules,
"leaveDotGit" A..= _leaveDotGit,
"sparseCheckout" A..= _sparseCheckout,
"name" A..= _name,
"sha256" A..= _sha256,
"type" A..= A.String "github"
Expand Down Expand Up @@ -514,7 +518,8 @@ instance Pretty (NixFetcher k) where
"rev" <> colon <+> pretty _rev,
"deepClone" <> colon <+> pretty _deepClone,
"fetchSubmodules" <> colon <+> pretty _fetchSubmodules,
"leaveDotGit" <> colon <+> pretty _leaveDotGit
"leaveDotGit" <> colon <+> pretty _leaveDotGit,
"sparseCheckout" <> colon <+> pretty _sparseCheckout
]
<> ppField "name" _name
)
Expand All @@ -529,7 +534,8 @@ instance Pretty (NixFetcher k) where
"rev" <> colon <+> pretty _rev,
"deepClone" <> colon <+> pretty _deepClone,
"fetchSubmodules" <> colon <+> pretty _fetchSubmodules,
"leaveDotGit" <> colon <+> pretty _leaveDotGit
"leaveDotGit" <> colon <+> pretty _leaveDotGit,
"sparseCheckout" <> colon <+> pretty _sparseCheckout
]
<> ppField "name" _name
)
Expand Down
1 change: 1 addition & 0 deletions test/NixExprSpec.hs
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ spec = describe "toNixExpr" $ do
fetchSubmodules = true;
deepClone = false;
leaveDotGit = false;
sparseCheckout = [ ];
sha256 = "0000000000000000000000000000000000000000000000000000000000000000";
}
|]
Expand Down