Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Dark theme implementation #2

Open
beradeep opened this issue Dec 6, 2023 · 13 comments
Open

[feat] Dark theme implementation #2

beradeep opened this issue Dec 6, 2023 · 13 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs

Comments

@beradeep
Copy link
Owner

beradeep commented Dec 6, 2023

Implement night/dark theme colors and UI for the app.

@beradeep beradeep added enhancement New feature or request good first issue Good for newcomers up for grabs labels Dec 6, 2023
@abhay-ajith
Copy link

Hi,
Is the issue to change the theme to dark or being able to toggle between.

@beradeep
Copy link
Owner Author

beradeep commented Dec 21, 2023

@abhay-ajith It is not an issue. The dark theme needs to be implemented as a new feature by creating a separate darkColorPalette for the dark theme. Having the option to toggle between light and dark themes is a plus.

@JonibekXolmonov
Copy link
Contributor

Are the colors inside _darkColorScheme(now commented) real colors of dark mode?

@beradeep
Copy link
Owner Author

beradeep commented Apr 5, 2024

Yes, they were actually supposed to be the colors for dark mode. But most parts of the codebase right now has colors hardcoded only for light mode, for that reason dark mode is disabled for now. These need to be replaced with colors from the colorSchemes using MaterialTheme.colorScheme, for consistency in both the modes.

@JonibekXolmonov
Copy link
Contributor

I give it a try.

@beradeep
Copy link
Owner Author

beradeep commented Apr 10, 2024

I give it a try.

Hi, are you working on it?

@JonibekXolmonov
Copy link
Contributor

Hi, since you assigned me, I have been stuck in university tasks and then 2 day holiday, from tomorrow I begin working. I am so sorry to be late

@beradeep
Copy link
Owner Author

Hi, no need to be sorry 😄, thanks for informing!

@JonibekXolmonov
Copy link
Contributor

🤝🤝

@beradeep
Copy link
Owner Author

Hi, are you still working on this?

@JonibekXolmonov
Copy link
Contributor

Hi sir, can you unassign me? Because of my studies at the university,diploma thesis and prior-graduation practice, I can't allocate time even to breathe.
As soon as I am free, I let you know and go on enhancing your project. I am really sorry not informing this earlier

@beradeep
Copy link
Owner Author

beradeep commented May 5, 2024

Hi, it's okay. I just wanted to know if there's any update. As per your request, I am unassigning you right now. Just let me know if you start working on this again.

@JonibekXolmonov
Copy link
Contributor

Sure,🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers up for grabs
Projects
None yet
Development

No branches or pull requests

3 participants