Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Order Ahead Only" items in On Demand #510

Open
vcardillo opened this issue Feb 18, 2016 · 9 comments
Open

Show "Order Ahead Only" items in On Demand #510

vcardillo opened this issue Feb 18, 2016 · 9 comments

Comments

@vcardillo
Copy link
Member

For each menu item that's in OA, but not in OD, show the item in OD, at the bottom of the list, but above "sold out" items, with a banner that says oa-only-od-banner.

Use OAOnlyItems, pictured below, to automatically tell you which items are OA only. If there are no OA Only items, then the array will be empty.

When the item is tapped, the functionality is the same as a sold out item, except the button says oa-only-od-btn

@demant
Copy link

demant commented Feb 18, 2016

How many characters can we fit on that banner?

On Feb 17, 2016, at 4:22 PM, Vincent Cardillo [email protected] wrote:

Look at the menu items for OA. For each menu item that's in OA, but not in OD, show the item in OD, at the bottom of the list, but above "sold out" items, with a banner that says oa-only-od-banner.


Reply to this email directly or view it on GitHub.

@vcardillo
Copy link
Member Author

Joseph pointed out the problem that he can't compare items past 10am/3pm, because the OA menu goes away. In response, I've added OA only items to a special place in the existing OD menu JSON:

screen shot 2016-02-18 at 12 38 02 pm

Now you can just use this to directly augment as described above. No need to even compare anymore.

On dev.

@vcardillo
Copy link
Member Author

There isn't room on the banner, so I've suggested to Joseph to just run the banner across the top of the item. cc @xkokushox

@josephlausf
Copy link
Contributor

How's this: http://recordit.co/f2lDyv1HFH

@vcardillo
Copy link
Member Author

Looks good. But you are using the wrong copy for the banner. Use oa-only-od-banner. I think you are using the btn.

@josephlausf
Copy link
Contributor

Oh yeah, fixed -> http://recordit.co/6FX9929wav

@vcardillo
Copy link
Member Author

Kewl and sorry, one last thing, I changed it to "Available Only with Order Ahead". Can you make sure it fits okay?

@josephlausf
Copy link
Contributor

got it -> http://recordit.co/dcJuJaXchP

@vcardillo
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants