Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map logic #408

Open
vcardillo opened this issue Feb 18, 2016 · 3 comments
Open

Map logic #408

vcardillo opened this issue Feb 18, 2016 · 3 comments

Comments

@vcardillo
Copy link
Member

cc @demant @josephlausf

The map for Android is showing as the first screen every time I open the app, even when I am already inside of the zone, or have already entered a prior address into the app. This isn't correct. It's only supposed to do this if I am outside of the zone.

@josephlausf: What is the correct flow here?

@vcardillo vcardillo added this to the 1.22 [current] milestone Feb 18, 2016
@josephlausf
Copy link

  • isGPSEnabled?
    • true -> didGPSSucceedInRetrievingLocation?
      • true -> isInZone
        • true -> don't show map
        • false -> show map
      • false -> isThereSavedAddress?
        • true -> don't show map
        • false -> show map
    • false -> isThereSavedAddress?
      • true -> don't show map
      • false -> show map

@vcardillo
Copy link
Member Author

👍

@vcardillo vcardillo removed this from the 1.22 [current] milestone Feb 23, 2016
@vcardillo
Copy link
Member Author

We need to hold on this. The flow has a bug. The issue is that a saved address could be inside OA, but outside of OD, and in that case, this flow would never show the user OD.

xkokushox pushed a commit that referenced this issue Feb 23, 2016
xkokushox pushed a commit that referenced this issue Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants