Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GAT-BEA002-32] [Settings/Profile] - CTA button label is incorrect if user is editing the credit card details. #396

Open
gatgithub opened this issue Feb 4, 2016 · 3 comments

Comments

@gatgithub
Copy link

Issue No: 32
Device: Samsung Galaxy Tab 2 Android 4.1.2

Affected Component(s)

  • Settings / Profile

Bug Description

[Settings/Profile] - CTA button label is incorrect if user is editing the credit card details.

ACTUAL RESULTS:-
CTA button label is incorrect if user is editing the credit card details under settings and not ordering anything. The label says "Continue to Summary".

EXPECTED RESULTS:-
If the user is only editing the credit card details and not ordering, the CTA button label should say "Save" not "Continue to Summary".

OTHER NOTES / ERROR MESSAGES:-
.

http://bugs8.gatserver.com/uploads/85651a5f82af51ad8196473b506199c7.mp4


Reproduction Steps

    1. Login to the app using the specified credentials.
    1. Set the location to "San Francisco, CA, US".
    1. Tap the profile CTA button on the top left.
    1. On the settings menu, select "Credit Card".
  • Observe that the CTA button label is "Continue to Summary" instead of "Save".
@gatgithub gatgithub added this to the 1.11 [prior] milestone Feb 4, 2016
@gatgithub gatgithub removed this from the 1.11 [prior] milestone Feb 4, 2016
@vcardillo vcardillo added this to the 1.21 Order Ahead [current] milestone Feb 5, 2016
@vcardillo
Copy link
Member

This button needs to be completely removed from this screen.

xkokushox pushed a commit that referenced this issue Feb 6, 2016
- Done #401
- Done #400
- Done #398
- Done #396
- Done #394
- Done #393
- Done #385
- Done #384
- Done #383
- Done #381
- Done #379
- Done #377
- Done #368
- Done #364
- Done #365
- Done #360
- Done #355
- Done #354
@gatgithub
Copy link
Author

Verified fixed - 12.02.2016

@vcardillo
Copy link
Member

@xkokushox Can you make a video of what it's doing now? First-time use vs subsequent use.

@vcardillo vcardillo modified the milestones: 1.22 [current], 1.21 Order Ahead [prior] Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants