Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GAT-BEA002-28] If the user opens the app with his device's time set to the last day available in the current delivery schedule, and order a bento scheduled for delivery 1 day before the day he set in his device, the app will crash #394

Open
gatgithub opened this issue Feb 4, 2016 · 4 comments
Open

[GAT-BEA002-28] If the user opens the app with his device's time set to the last day available in the current delivery schedule, and order a bento scheduled for delivery 1 day before the day he set in his device, the app will crash #394

gatgithub opened this issue Feb 4, 2016 · 4 comments
Labels
bug critical fromGAT qa-ready
Milestone
1.22 [prior]

Comments

@gatgithub
Copy link

Issue No: 28
Device: Alcatel Onetouch Pop D5 Android 4.4.2

Affected Component(s)

  • Build your Bento (Home screen)

Bug Description

ACTUAL RESULTS:-
If the user opens the app with his device's time set to the last day available in the current delivery schedule, and order a bento scheduled for delivery 1 day before the day he set in his device, the app will crash

EXPECTED RESULTS:-
It is expected that the app should be not based on the device's time but on their server's time.

OTHER NOTES / ERROR MESSAGES:-

Reproduction Steps

  • Set your device's time to the last day on the Delivery schedule. (feb 5)
  • Open the app, enter San francisco as the location and login
  • Set the delivery schedule to 1 day before the device's date. ( feb 4). Accept
  • Let the app finish your bento by tapping the button at the top right
  • Tap Yes. Observe
@gatgithub gatgithub added this to the 1.11 [prior] milestone Feb 4, 2016
@gatgithub gatgithub removed this from the 1.11 [prior] milestone Feb 4, 2016
@vcardillo vcardillo added this to the 1.21 Order Ahead [current] milestone Feb 5, 2016
xkokushox pushed a commit that referenced this issue Feb 5, 2016
- Done #394
3d1f351 
- Done #353
xkokushox pushed a commit that referenced this issue Feb 6, 2016
- Done #403
788a43b 
- Done #401
- Done #400
- Done #398
- Done #396
- Done #394
- Done #393
- Done #385
- Done #384
- Done #383
- Done #381
- Done #379
- Done #377
- Done #368
- Done #364
- Done #365
- Done #360
- Done #355
- Done #354
@gatgithub
Copy link
Author

Still Present - 12.02.2016

Log: http://bugs8.gatserver.com/uploads/890ac1060fc2b8ad1c9cccc8df14b3c1.txt
Video: http://bugs8.gatserver.com/uploads/05b62f3d99e6416a9e579b69b2aa141c.mp4

Device - Samsung Galaxy Note 3 - 4.4.2
App version - 1.21-rc11-Dev

Steps to reproduce:

Set your device's time to the last day on the Delivery schedule
Run the app and log in
Set the delivery schedule to 1 day before the device's date. ( feb 4)
Tap the Accept button
Notice that the app will crash

xkokushox pushed a commit that referenced this issue Feb 13, 2016
- Done #394
5c5ac0e
@vcardillo vcardillo modified the milestones: 1.22 [current], 1.21 Order Ahead [prior] Feb 18, 2016
@xkokushox
Copy link
Contributor

@vcardillo that one was fixed in 1.21-rc12-dev and is the same bug as #412

@vcardillo
Copy link
Member

The bugs seem unrelated...

@vcardillo
Copy link
Member

vincent [11:32 AM]
re: #394 (comment)

[11:32]
Those seem like different bugs

jose.torres [11:32 AM]
the problem was in the code

new messages
[11:33]
i wasnt checking a variable and was null

vincent [11:39 AM]
ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug critical fromGAT qa-ready
Projects
None yet
Milestone
1.22 [prior]
Development

No branches or pull requests
3 participants
@vcardillo @xkokushox @gatgithub