forked from t-evans/django-threadlocalrequest
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for Django 3.2 #15
Comments
This works if you're looking for contextvars, but I wonder what problem you have with Django 3.2, django-threadlocals seems to be working fine for me ... from contextvars import ContextVar
context_request = ContextVar('request')
def middleware(get_response):
def middleware(request):
token = context_request.set(request)
response = get_response(request)
context_request.reset(token)
return response
return middleware |
Tasawar,
I'm not an active software developer at this point, so no plans to make any
upgrades other than merging PR's if they catch my attention. I'd be happy
to transfer ownership to you if it's helpful and that's the right approach.
…On Tue, Nov 23, 2021 at 7:11 PM jpic ∞ ***@***.***> wrote:
This works if you're looking for contextvars, but I wonder what problem
you have with Django 3.2 it works fine for me ...
from contextvars import ContextVar
context_request = ContextVar('request')
def middleware(get_response):
def middleware(request):
token = context_request.set(request)
response = get_response(request)
context_request.reset(token)
return response
return middleware
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFK7QXGLH36UPFSVSWQT63UNRCVLANCNFSM5DK6MDCQ>
.
|
@benrobster sure thing, please transfer its ownership and I will try to upgrade it to match django 3.2 if it requires any modification. |
Upgrade to Django 3.2 would surely be interesting to see in a PR!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm interested in contributing to the edX open-source project. I was wondering if you guys have a plan to upgrade this package to make it compatible with Django 3.2.
I am happy to help if needed.
You can find the associated edX Django upgrade Github issues here.
The text was updated successfully, but these errors were encountered: