Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember.inflector() is deprecated; Update README (resolves issue #6) #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

delusioninabox
Copy link

Ember.inflector() is deprecated notice message appears in Ember console. Replace with latest vers from docs.

@delusioninabox delusioninabox changed the title Ember.inflector() is deprecated Ember.inflector() is deprecated; Update README (resolves issue #6) Feb 19, 2018
@benoror
Copy link
Owner

benoror commented Feb 19, 2018

@delusioninabox awesome work! thanks!

@benoror
Copy link
Owner

benoror commented Feb 19, 2018

@delusioninabox do you mind checking out the failing tests?

@delusioninabox
Copy link
Author

@benoror Will do! 👀

@delusioninabox
Copy link
Author

It looks like the error has to do with this line: container.lookupFactory('adapter:application') (in test-helper.js) but I haven't been able to resolve it yet. Looks like it needs to be replaced with something like this.owner.lookup('adapter:application') from what I could look up so far.
https://guides.emberjs.com/v3.0.0/testing/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants