Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Scroll overflow issues on the pack screen in safari and on mobile #58

Open
benhoneywill opened this issue May 17, 2022 · 2 comments
Open
Labels
bug Something isn't working

Comments

@benhoneywill
Copy link
Owner

In safari the category columns overflow the viewport and can't be scrolled.

On mobile the same issue can sometimes occur. It seems to be due to the use of view height units

@benhoneywill benhoneywill added the bug Something isn't working label May 17, 2022
@Alex-AK
Copy link

Alex-AK commented Jun 7, 2022

I found this article on mobile view height calculation helpful for addressing the issue on other projects I've worked on. This is likely from the fixed-layout.tsx use of height="100vh".

@benhoneywill
Copy link
Owner Author

benhoneywill commented Jun 8, 2022

Hi @Alex-AK thanks for the link!

I will read that article properly when I get the chance. Looks like they are using window.innerHeight which means this solution may not work with server side rendering, but when I am free to pick up this issue I will keep this technique in mind. It might work fine with a default value!

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants