Fix panic in Python 3.12 line number handling #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The read_varint function would panic when trying to read past the end of the line table. This fix adds bounds checking and returns Option<usize> to handle this case gracefully. Fixes benfred#735
|
Nice! Do you know what the user-facing effect of this is? What happens when the delta is unwrapped to zero? |
|
@zanieb It will assume that code is on the same line as the previous code and not crash with an index out of bounds error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The read_varint function would panic when trying to read past the end of the line table. This fix adds bounds checking and returns Option to handle this case gracefully.
Changes:
Fixes #735