From 969c4dfa89813d56c794677598c64ae0af2f97e0 Mon Sep 17 00:00:00 2001 From: Ben Frederickson Date: Thu, 31 Oct 2024 11:29:07 -0700 Subject: [PATCH] Test macos py3.11 in CI (#710) --- .github/workflows/build.yml | 2 -- ci/update_python_test_versions.py | 4 ++-- tests/integration_test.py | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index b781802b..85968bb4 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -218,8 +218,6 @@ jobs: os: [ubuntu-20.04, macos-13] # some versions of python can't be tested on GHA with osx because of SIP: exclude: - - os: macos-13 - python-version: 3.11.0 - os: macos-13 python-version: 3.11.10 - os: macos-13 diff --git a/ci/update_python_test_versions.py b/ci/update_python_test_versions.py index ade39130..d8564648 100644 --- a/ci/update_python_test_versions.py +++ b/ci/update_python_test_versions.py @@ -9,7 +9,7 @@ def parse_version(v): - return tuple(int(part) for part in re.split("\W", v)[:3]) + return tuple(int(part) for part in re.split(r"\W", v)[:3]) def get_github_python_versions(): @@ -82,7 +82,7 @@ def update_python_test_versions(): # since it currently fails in GHA on SIP errors exclusions = [] for v in versions: - if v.startswith("3.11") or v.startswith("3.12"): + if v.startswith("3.11.10") or v.startswith("3.12"): exclusions.append(" - os: macos-13\n") exclusions.append(f" python-version: {v}\n") first_exclude_line = lines.index(" exclude:\n", first_line) diff --git a/tests/integration_test.py b/tests/integration_test.py index e5f56557..7408dd8d 100644 --- a/tests/integration_test.py +++ b/tests/integration_test.py @@ -43,7 +43,8 @@ def _sample_process(self, script_name, options=None, include_profile_name=False) ] cmdline.extend(options or []) cmdline.extend(["--", sys.executable, script_name]) - subprocess.check_output(cmdline) + env = dict(os.environ, RUST_LOG="debug") + subprocess.check_output(cmdline, env=env) with open(profile_file.name) as f: profiles = json.load(f)