Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit dialog style inclusion #21

Open
bendavis78 opened this issue Dec 10, 2015 · 2 comments
Open

Remove implicit dialog style inclusion #21

bendavis78 opened this issue Dec 10, 2015 · 2 comments
Milestone

Comments

@bendavis78
Copy link
Owner

The dialog style is currently included in the main html file for backward compatibility. This should be removed in the next version.

@bendavis78 bendavis78 added this to the 1.2 milestone Dec 10, 2015
@zmoshansky
Copy link

@bendavis78 When this happens, what will be the proper way of including the style? I currently need to have <style is="custom-style" include="paper-time-picker-dialog-style"></style> in the element where the dialog is hosted (tested on paper-time-picker 1.1 & master).

I've also added a match shim to pull the header all the way to the bottom in landscape.

<template>
    <style>
      :host { display: block; }
      @media (max-width: 560px) {
        .match {
          height: 0;
          width: 0;
        }
      }
      @media (min-width: 561px) {
        .match {
        width: 168px;
        height: 56px;
        position: absolute;
        left: 0px;
        bottom: 0px;
        background: var(--default-primary-color);
        }
      }
    </style>

    <style is="custom-style" include="paper-time-picker-dialog-style"></style>
    <paper-dialog id="dialog" modal class="paper-time-picker-dialog">
      <paper-time-picker id="timePicker"></paper-time-picker>
      <div class="buttons">
        <span class="match"></span>
        <paper-button dialog-dismiss>Cancel</paper-button>
        <paper-button dialog-confirm on-tap="close">OK</paper-button>
      </div>
    </paper-dialog>
  </template>

@bendavis78 bendavis78 changed the title [deprecate] remove implicit dialog style inclusion Remove implicit dialog style inclusion Feb 29, 2016
@admwx7
Copy link
Collaborator

admwx7 commented Sep 19, 2017

Going to move this to the 2.0 milestone since it's a breaking change. Part of that will be converting to Polymer 2.0 as well.

@admwx7 admwx7 modified the milestones: 1.2, 2.0 Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants