-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24 hours based time selection #1
Comments
Ah, I was wondering about how the material spec would handle that. I'll look into implementing this soon. Let me know if you notice any other i18n issues in the time/date pickers. |
Hey, great job on this component. I looked at my android phone and the design looks a bit like this (two circles, one for 0-12 and the other one for 13-24). Maybe you should have a look. |
Looking forward to seeing this here as well. An example of the implementation from React Material Ui: http://material-ui.com/#/components/time-picker |
+1 |
1 similar comment
+1 |
Hi , |
@bendavis78 is this something we should expect soon? |
+1 |
FYI : I just hacked my fork to use the 24 hour-format, but I took the easy route not completely matching the material spec :>. I didn't implement a switch as I don't need it currently, but maybe it helps somebody stumbling accross this issue & searching for a fast workaround. Unfortunately my code-formatter changed some indents as well making it a bit hard to see what I actually changed, so here are the line numbers : That's it :> |
+1 |
Looks like this is a pretty popular request, we've got the start of a PR out for this that needs some love. Once I move to hybrid and get everything tested I'll take a stab at adding this functionality if #52 isn't updated by then. |
First of all, great work !
Your components for date / time picking are great. I only have an issue for those of us in Europe using 24 hours based time :)
I investigated and it seems Google is quite unclear on the subject : The time picker as depicted at http://www.google.com/design/spec/components/pickers.html#pickers-time-pickers only shows an AM/PM 12 hours based time picker...
I use an iPhone so I can't verify but, it seems Google Calendar on Android as a UX solution for that : http://googlesystem.blogspot.fr/2013/05/new-google-calendar-controls-for-android.html
Any chance you could implement it ?
The text was updated successfully, but these errors were encountered: