Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 hours based time selection #1

Open
cedric-marcone opened this issue May 14, 2015 · 11 comments
Open

24 hours based time selection #1

cedric-marcone opened this issue May 14, 2015 · 11 comments
Milestone

Comments

@cedric-marcone
Copy link

First of all, great work !
Your components for date / time picking are great. I only have an issue for those of us in Europe using 24 hours based time :)

I investigated and it seems Google is quite unclear on the subject : The time picker as depicted at http://www.google.com/design/spec/components/pickers.html#pickers-time-pickers only shows an AM/PM 12 hours based time picker...

I use an iPhone so I can't verify but, it seems Google Calendar on Android as a UX solution for that : http://googlesystem.blogspot.fr/2013/05/new-google-calendar-controls-for-android.html

Any chance you could implement it ?

@bendavis78
Copy link
Owner

Ah, I was wondering about how the material spec would handle that. I'll look into implementing this soon. Let me know if you notice any other i18n issues in the time/date pickers.

@freijbe
Copy link

freijbe commented Aug 13, 2015

Hey, great job on this component.

I looked at my android phone and the design looks a bit like this (two circles, one for 0-12 and the other one for 13-24).

Maybe you should have a look.

@zalmoxisus
Copy link

Looking forward to seeing this here as well. An example of the implementation from React Material Ui: http://material-ui.com/#/components/time-picker

@celevra
Copy link

celevra commented Oct 11, 2015

+1

1 similar comment
@ghost
Copy link

ghost commented Nov 8, 2015

+1

@bendavis78 bendavis78 modified the milestones: 1.1, 1.2, 1.1.1 Nov 24, 2015
@sapna1402
Copy link

Hi ,
Any updates regarding this?

@bendavis78 bendavis78 modified the milestones: 1.1.2, 1.1.1 Dec 10, 2015
@rubenstolk
Copy link

@bendavis78 is this something we should expect soon?

@SPAHI4
Copy link

SPAHI4 commented Jun 23, 2016

+1

@Compufreak345
Copy link

Compufreak345 commented Sep 7, 2016

FYI : I just hacked my fork to use the 24 hour-format, but I took the easy route not completely matching the material spec :>. I didn't implement a switch as I don't need it currently, but maybe it helps somebody stumbling accross this issue & searching for a fast workaround.

24 hour picker

Compufreak345@dcaa2fb

Unfortunately my code-formatter changed some indents as well making it a bit hard to see what I actually changed, so here are the line numbers :
paper-clock-selector.html => Line 110 - make it to display up to 24 entries
paper-time-picker.html :
Line 182 -> show hours instead of hours12
Line 190-193 -> remove AM/PM display
Line 196/197 -> tell the picker to show zero and 24 hours instead of 12, use hour instead of hour12

That's it :>

@Arrvi
Copy link

Arrvi commented May 29, 2017

+1

@admwx7
Copy link
Collaborator

admwx7 commented Sep 14, 2017

Looks like this is a pretty popular request, we've got the start of a PR out for this that needs some love. Once I move to hybrid and get everything tested I'll take a stab at adding this functionality if #52 isn't updated by then.

@admwx7 admwx7 modified the milestones: 1.1.2, 1.3 Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests