-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow writing index.html, data.js without pushing to gh-pages #85
Comments
Second that. I struggle to get the html and js file out of the action without any commits, pushes fetches etc. Any plans to make this work? It looks like removing the call to |
What do you mean by this? Can you be more specific? |
I guess having these files as artifacts would be great. Then users can decide what to do with them and where and when. Does that make sense? |
I'd like to see this extended to inputs as well. HTML generation should not required Git at all:
|
I actually was able to work around this issue, I don't remember exactly how it works: Convert the json into a js file echo 'window.BENCHMARK_DATA = ' | cat - "$WWW_DIR/bench/data.json" > "$WWW_DIR/bench/data.js" Just to write the node --input-type=module -e "$(curl -sSL https://raw.githubusercontent.com/benchmark-action/github-action-benchmark/master/src/default_index_html.ts) console.log(DEFAULT_INDEX_HTML)" > "$WWW_DIR/bench/index.html" |
Why not store these files as job artifacts? Other actions (e.g. code-coverage-report-action) do it like this and it works quite well. |
I believe workflows cannot access artifacts from previous runs. |
AFAIK this works with code-coverage-report-action via the GH REST API. |
On our gh-pages branch we have a few different things, docs, other benchmarks, etc, and I want finer-grain control over how things are pushed to the branch. I think it makes sense to have an option that outputs these assets (edit: i.e. as html+js files, in a particular directory, without uploading them to git) to the user to let them do what they want with them.
The text was updated successfully, but these errors were encountered: