Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom type with combined bigger/smaller is better #84

Open
michaelmior opened this issue Oct 29, 2021 · 1 comment
Open

Custom type with combined bigger/smaller is better #84

michaelmior opened this issue Oct 29, 2021 · 1 comment

Comments

@michaelmior
Copy link
Contributor

michaelmior commented Oct 29, 2021

In addition to customBiggerIsBetter and customSmallerIsBetter it would be nice to just have a simple custom type where the JSON output would include "better": "bigger" or "better": "smaller" so that a single benchmark could make use of both. For example, I might want to measure both memory use (smaller is better) and throughput (bigger is better) for a single benchmark. While I could potentially save the results to a file and split them apart into two separate benchmark outputs, it would be simpler if this was not necessary.

EDIT: Having a quick look at the current code structure, I can see this probably isn't easy to do but it still would be nice :)

@ktrz
Copy link
Member

ktrz commented Oct 29, 2021

hi @michaelmior

Thank you for your suggestion. I actually did something similar on another project by refactoring this project's code a bit. I might take a try on applying a similar refactor here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants