Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]it doesn't work with output of table driven benchmarks in go #77

Open
cnlangzi opened this issue Sep 14, 2021 · 3 comments
Open

[bug]it doesn't work with output of table driven benchmarks in go #77

cnlangzi opened this issue Sep 14, 2021 · 3 comments

Comments

@cnlangzi
Copy link

the output is

goos: darwin
goarch: amd64
pkg: github.com/0chain/gosdk/zboxcore/sdk
cpu: Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz
BenchmarkChunkedUploadFormBuilder/10M_64K-8         	      39	 312026046 ns/op	264405427 B/op	 1799151 allocs/op
BenchmarkChunkedUploadFormBuilder/10M_6M-8          	     318	  38583357 ns/op	35552045 B/op	   30195 allocs/op
BenchmarkChunkedUploadFormBuilder/10M_64K_NoHash-8  	      37	 305542242 ns/op	264406763 B/op	 1799159 allocs/op
BenchmarkChunkedUploadFormBuilder/10M_6M__NoHash-8  	     315	  39228720 ns/op	35551235 B/op	   30194 allocs/op
BenchmarkChunkedUploadFormBuilder/100M_64K-8        	       4	3097868954 ns/op	2665191370 B/op	18111513 allocs/op
BenchmarkChunkedUploadFormBuilder/100M_6M-8         	      32	 371133831 ns/op	343483354 B/op	  216628 allocs/op
BenchmarkChunkedUploadFormBuilder/100M_64K_NoHash-8 	       4	2947383724 ns/op	2665200902 B/op	18111571 allocs/op
BenchmarkChunkedUploadFormBuilder/100M_6M__NoHash-8 	      31	 349546589 ns/op	343483543 B/op	  216629 allocs/op
BenchmarkChunkedUploadFormBuilder/500M_64K-8        	       1	15473948734 ns/op	13335867688 B/op	90618221 allocs/op
BenchmarkChunkedUploadFormBuilder/500M_6M-8         	       6	1757071474 ns/op	1700784817 B/op	  977624 allocs/op
BenchmarkChunkedUploadFormBuilder/500M_64K_NoHash-8 	       1	14786519545 ns/op	13335866840 B/op	90618212 allocs/op
BenchmarkChunkedUploadFormBuilder/500M_6M__NoHash-8 	       6	1775155434 ns/op	1700785812 B/op	  977628 allocs/op
BenchmarkChunkedUploadFormBuilder/1G_64K-8          	       1	31321023689 ns/op	27328158144 B/op	185675100 allocs/op
BenchmarkChunkedUploadFormBuilder/1G_60M-8

https://github.com/rhysd/github-action-benchmark/blob/a1914d7dcbe14d006e4b5f12c7ff303a82a411f1/src/extract.ts#L211
const reExtract = /^(Benchmark\w+)(-\d+)?\s+(\d+)\s+([0-9.]+)\s+(.+)$/; does not work

@cnlangzi
Copy link
Author

fixed it in #78

@miparnisari
Copy link
Contributor

This was fixed in #32

@jaqx0r
Copy link

jaqx0r commented May 4, 2024

I am setting up a new workflow and I don't see this working.

https://github.com/google/mtail/actions/runs/8950770002/job/24586426328

The -.* suffix is still being stripped from the names of the table-driven runs.

I'm using v1.20.1, the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants