Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert when performance is improved #57

Open
ilias-t opened this issue Feb 24, 2021 · 3 comments
Open

Alert when performance is improved #57

ilias-t opened this issue Feb 24, 2021 · 3 comments

Comments

@ilias-t
Copy link

ilias-t commented Feb 24, 2021

Note this is a feature request.

When configuring the action, it would be nice to have the ability specify an option that shows an alert if the performance is improved by the defined threshold.

Also, thanks for this action—it's great!

@ilias-t ilias-t changed the title Ability to have an alert when performance is improved Alert when performance is improved Feb 24, 2021
@clicketyclackety
Copy link

Would putting the alert-threshold to "90%" work? 😊

@ilias-t
Copy link
Author

ilias-t commented Mar 12, 2022

As a user, an option in the config that allowed be to enable/disable a performance improvement alert with a custom threshold would be ideal!

@ilias-t
Copy link
Author

ilias-t commented Mar 12, 2022

Beyond that, I'd suggest having it disabled by default to make the change more backwards compatible. The config for this improved alert could receive a boolean to match the threshold/settings for the degradation alert or take a config object to be customized with its own threshold, etc. That'd be pretty sweet 💅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants