Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wrapping on GitHub comments for benchmarks with long names #263

Open
jviotti opened this issue Sep 13, 2024 · 2 comments
Open

Improve wrapping on GitHub comments for benchmarks with long names #263

jviotti opened this issue Sep 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jviotti
Copy link

jviotti commented Sep 13, 2024

I wonder if there is any way to improve the readability of the tables posted by this action when the benchmark names are too long. Take this one for example. We are finding it very hard to read the numbers given the last column gets wrapped.

Screenshot 2024-09-13 at 11 28 28 AM

Shorter benchmark names surely help, but it also sucks to sacrifice on their readability to make them fit... Maybe it would make sense to not put the benchmark case names on the first columns as code blocks using back ticks?

Or maybe there is a way to completely prevent the last column from wrapping? I much rather have the first column wrap.

@jviotti
Copy link
Author

jviotti commented Sep 13, 2024

Another option might be not include so much precision on the current/previous columns? For example, there is probably no difference between showing 151.74767917302637 and 151.7 us and that could make some significant space?

@ktrz
Copy link
Member

ktrz commented Sep 15, 2024

Thank you @jviotti for submitting this issue! I'll have a look at what options are available to make this more readable. We could probably get some additional space back by moving the units to a separate column so that ns/iter only occurs once.

@ktrz ktrz added the enhancement New feature or request label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants