Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json file translations? #27

Open
jamesmills opened this issue May 19, 2019 · 3 comments
Open

json file translations? #27

jamesmills opened this issue May 19, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jamesmills
Copy link

Hi,

Love this package, works great, thank you!

Do you plan to add support for Translation Strings (json) files as well as the Translation Strings

Thanks, James

@ben182
Copy link
Owner

ben182 commented May 19, 2019

Hi James,

thanks thats actually a really good idea. What do you mean by Translation String btw?

@jamesmills
Copy link
Author

Hi Ben,

Thanks for your speedy reply!

We are going to be using the "Using Translation Strings As Keys" found in the docs on this page https://laravel.com/docs/5.8/localization#defining-translation-strings quite a lot. It's going to be easier for us to translate larger parts of our application using these and not the simple key/pair options in the .php files.

I was wondering if you had plans to also loop and translate the entries in these files too?

Thanks, James

@jamesmills
Copy link
Author

Looks like this package does the .json files too https://github.com/tanmuhittin/laravel-google-translate

@ben182 ben182 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants