Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused code #94

Open
groninge01 opened this issue Apr 24, 2022 · 4 comments
Open

Remove unused code #94

groninge01 opened this issue Apr 24, 2022 · 4 comments

Comments

@groninge01
Copy link

groninge01 commented Apr 24, 2022

@danielmkm

App.vue:

  • useGnosisSafeApp: what is this and do we need it?
  • useExploitWatcher: this currently only holds 1 exploit, Sorbet Finance which is only active on Ethereum -> REMOVE?
@danielmkm
Copy link

useGnosisSafeApp could be useful at some point, but isn't being used now, it allows easier interaction with the app with a multisig.

useExploitWatcher what does it do when you has an address that is part of an exploit?

@groninge01
Copy link
Author

useExploitWatcher what does it do when you has an address that is part of an exploit?

You get an alert with a message. I checked the balancer version and it is still the same.

@danielmkm
Copy link

ok, get rid of it then

@groninge01
Copy link
Author

@danielmkm

AppNavSettings: What are these v-if's about?

<div v-if="!hideLiquidity" class="px-4 mt-6">
    <div class="flex items-baseline">
        <span v-text="$t('tradeLiquidity')" class="font-medium mb-2" />
        <BalTooltip>
            <template v-slot:activator>
                <BalIcon name="info" size="xs" class="ml-1 text-gray-400 -mb-px" />
            </template>
            <div v-text="$t('whichPools')" />
        </BalTooltip>
    </div>
    <BalBtnGroup :options="tradeLiquidityOptions" v-model="appTradeLiquidity" @update:modelValue="setTradeLiquidity" />
</div>
<div v-if="isEIP1559SupportedNetwork" class="px-4 mt-6">
    <div class="flex items-baseline">
        <span v-text="$t('transactionType')" class="font-medium mb-2" />
        <BalTooltip>
            <template v-slot:activator>
                <BalIcon name="info" size="xs" class="ml-1 text-gray-400 -mb-px" />
            </template>
            <div v-text="$t('ethereumTxTypeTooltip')" />
        </BalTooltip>
    </div>
    <BalBtnGroup :options="ethereumTxTypeOptions" v-model="ethereumTxType" @update:modelValue="setEthereumTxType" />
</div>
<div v-if="ENABLE_LEGACY_TRADE_INTERFACE && isGnosisSupportedNetwork" class="px-4 mt-6">
    <div class="flex items-baseline">
        <span v-text="$t('tradeInterface')" class="font-medium mb-2" />
        <BalTooltip>
            <template v-slot:activator>
                <BalIcon name="info" size="xs" class="ml-1 text-gray-400 -mb-px" />
            </template>
            <div v-text="$t('tradeInterfaceTooltip')" class="w-52" />
        </BalTooltip>
    </div>
    <BalBtnGroup :options="tradeInterfaceOptions" v-model="appTradeInterface" @update:modelValue="setTradeInterface" />
    <div class="flex mt-1"></div>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants