Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 canary #631

Merged
merged 10 commits into from
Jan 9, 2024
Merged

V3 canary #631

merged 10 commits into from
Jan 9, 2024

Conversation

franzns
Copy link
Contributor

@franzns franzns commented Jan 9, 2024 •
edited
Loading

  • add sentry integrations
  • optimize lifetime value update
  • set cron intervals to standard on three balancer chains (mainnet, polygon, arb)
  • run purge token prices only once for all chains

@franzns franzns requested a review from gmbronco January 9, 2024 15:13
gmbronco
gmbronco approved these changes Jan 9, 2024
View reviewed changes
app.ts Outdated
tracesSampleRate: 0.2,
profilesSampleRate: 0.1,
tracesSampleRate: 0.005,
profilesSampleRate: 0.005,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one depends on tracesSampleRate, so now it's 0.005 of 0.005 total traces. we can leave it as 0.1 - 10% of traces.

modules/token/token.service.ts Outdated
Comment on lines 219 to 220
public async purgeOldTokenPricesForAllChains() {
await this.tokenPriceService.purgeOldTokenPricesForAllChains();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async / await can be skipped here, because we don't use results within the function and it returns a promise anyways

worker/worker.ts Outdated
tracesSampleRate: 0.2,
profilesSampleRate: 0.1,
tracesSampleRate: 0.005,
profilesSampleRate: 0.005,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as in the app

@franzns franzns merged commit 339fc55 into v3-main Jan 9, 2024
1 check passed
@franzns franzns mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmbronco gmbronco gmbronco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franzns @gmbronco