Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vebal rank sorting #542

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix vebal rank sorting #542

merged 1 commit into from
Dec 19, 2023

Conversation

mendesfabio
Copy link
Contributor

@mendesfabio mendesfabio requested a review from franzns November 29, 2023 11:18
@mendesfabio
Copy link
Contributor Author

@franzns curious if that's what you thought or should I instantiate and sort balances as big numbers

@franzns
Copy link
Contributor

franzns commented Nov 30, 2023

Should be fine to use numbers. Did you give it a test?

@mendesfabio
Copy link
Contributor Author

Should be fine to use numbers. Did you give it a test?

I took 10 random addresses from https://dune.com/balancer/vebal and ranking position matched. I believe this one is ready for merging

@franzns franzns merged commit 526cfbc into v3-canary Dec 19, 2023
1 check passed
@franzns franzns deleted the fix-vebal-ranking branch December 19, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzns franzns Awaiting requested review from franzns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mendesfabio @franzns