Don't assume AWS SDK sets ContentLength for get object

Fixes benbjohnson#556
beeper · Jan 5, 2024 · 07fc79c · 07fc79c
1 parent e71e685
commit 07fc79c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/s3/replica_client.go b/s3/replica_client.go
@@ -292,7 +292,9 @@ func (c *ReplicaClient) SnapshotReader(ctx context.Context, generation string, i
 		return nil, err
 	}
 	internal.OperationTotalCounterVec.WithLabelValues(ReplicaClientType, "GET").Inc()
-	internal.OperationBytesCounterVec.WithLabelValues(ReplicaClientType, "GET").Add(float64(*out.ContentLength))
+	if out.ContentLength != nil {
+		internal.OperationBytesCounterVec.WithLabelValues(ReplicaClientType, "GET").Add(float64(*out.ContentLength))
+	}
 
 	return out.Body, nil
 }
@@ -386,7 +388,9 @@ func (c *ReplicaClient) WALSegmentReader(ctx context.Context, pos litestream.Pos
 		return nil, err
 	}
 	internal.OperationTotalCounterVec.WithLabelValues(ReplicaClientType, "GET").Inc()
-	internal.OperationBytesCounterVec.WithLabelValues(ReplicaClientType, "GET").Add(float64(*out.ContentLength))
+	if out.ContentLength != nil {
+		internal.OperationBytesCounterVec.WithLabelValues(ReplicaClientType, "GET").Add(float64(*out.ContentLength))
+	}
 
 	return out.Body, nil
 }