You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We'll probably need to continue adding props (like tabletWidth or something) to suit the needs of all of the places where it is used.
Instead, it would be easier and more maintainable to make them more general purpose, then extending them for use in specific places. We could do this several ways:
Export them as simple components that only set up basic flex styles, then extend them later:
I removed the usage of the Flex containers on the PDP and PLP pages. I broke some of the styling in the process 🤦🏼♂️and probably should have left it alone. So now they are only used in the Checkout component. They're fine as-is, but let's deprecate them and, as you make any changes to Checkout, build out checkout-specific styled components
The text was updated successfully, but these errors were encountered:
I think that as the site grows, these
Flex
components are going to start getting more and more complicated:We'll probably need to continue adding props (like
tabletWidth
or something) to suit the needs of all of the places where it is used.Instead, it would be easier and more maintainable to make them more general purpose, then extending them for use in specific places. We could do this several ways:
I removed the usage of the Flex containers on the PDP and PLP pages. I broke some of the styling in the process 🤦🏼♂️and probably should have left it alone. So now they are only used in the Checkout component. They're fine as-is, but let's deprecate them and, as you make any changes to Checkout, build out checkout-specific styled components
The text was updated successfully, but these errors were encountered: