From 7ec78bd0e0bb056afc06760c2ec0c7bfe1098818 Mon Sep 17 00:00:00 2001 From: Sotirios Mantziaris Date: Sat, 29 Jun 2024 16:20:37 +0300 Subject: [PATCH] Refactor assertMetrics function in cache_test.go --- component/http/cache/cache_test.go | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/component/http/cache/cache_test.go b/component/http/cache/cache_test.go index 8dc441798..6ca01f931 100644 --- a/component/http/cache/cache_test.go +++ b/component/http/cache/cache_test.go @@ -1708,19 +1708,6 @@ func assertMetrics(t *testing.T, read *metricsdk.ManualReader) { t.Error("unexpected metric") } } - // TODO: check the right metrics are gathered!!! - // assert.Equal(t, 1, len(collectedMetrics.ScopeMetrics)) - // assert.Equal(t, 1, len(collectedMetrics.ScopeMetrics[0].Metrics)) - // assert.Equal(t, "http.cache.status", collectedMetrics.ScopeMetrics[0].Metrics[0].Name) - // assert.Equal(t, "http.cache.expiration", collectedMetrics.ScopeMetrics[0].Metrics[0].Name) - - // for k, v := range expected.values { - // // v.additions - // // v.errors - // // v.evictions - // // v.hits - // // v.misses - // } } type testingCacheEntity struct {