Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Navigation #1629

Open
9 tasks
SLDonnelly opened this issue Sep 23, 2024 · 5 comments · May be fixed by #1796
Open
9 tasks

Collapse Navigation #1629

SLDonnelly opened this issue Sep 23, 2024 · 5 comments · May be fixed by #1796
Assignees

Comments

@SLDonnelly
Copy link
Collaborator

SLDonnelly commented Sep 23, 2024

As a SPAR User I want *a collapse navigation feature So That I can collapse or show the left navigation panel

Acceptance Criteria

  • Show tooltip "Hide/Show navigation panel" on hover
  • When collapsing and opening the navigation panel again, keep the same menu item selected and submenu open/hidden as it was before

Additional Context

Definition of Done

  • Ready to Demo in Sprint Review
  • Does what I have made have appropriate test coverage?
  • Documentation and/or scientific documentation exists and can be found
  • Peer Reviewed by 2 people on the team
  • QA from UX
  • Manual testing of all PRs in Dev and Prod
  • Merged
@mgaseta
Copy link
Collaborator

mgaseta commented Dec 11, 2024

According with this comment in an issue at carbon repository...

Moving to blocked for now and updating it to 3 points.

@SLDonnelly
Copy link
Collaborator Author

Moving this ticket to be backlog as it got blocked in sprint 39. The carbon component does not support this functionality so review of other options will need to be done. A spike has been created in this ticket: #1780

@kevinginley
Copy link
Collaborator

@mgaseta
Collapse navigation looking good! If I have one nitpick, it's that, while the menu is expanded, the hover text on the expand/collapse button reads "Open menu" when clicking on that button would actually close the menu. Would it be possible to update the hover text on that button to read "Close menu" while the menu is expanded?

@mgaseta
Copy link
Collaborator

mgaseta commented Jan 6, 2025

@mgaseta Collapse navigation looking good! If I have one nitpick, it's that, while the menu is expanded, the hover text on the expand/collapse button reads "Open menu" when clicking on that button would actually close the menu. Would it be possible to update the hover text on that button to read "Close menu" while the menu is expanded?

Nice catch, thanks @kevinginley ! Fixed on my last commit, should be available to test after the deploy is updated.

@kevinginley
Copy link
Collaborator

It's been updated - looks good @mgaseta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants