Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namex: missing headoffice info for xpro-companies #24496

Open
eve-git opened this issue Nov 20, 2024 · 5 comments
Open

Namex: missing headoffice info for xpro-companies #24496

eve-git opened this issue Nov 20, 2024 · 5 comments
Assignees
Labels
High Priority Names Team Name Request Name Examination Team

Comments

@eve-git
Copy link
Collaborator

eve-git commented Nov 20, 2024

In Name Examination, when Solr identifies a name conflict with existing companies, the company information is retrieved and displayed in the UI as needed. The Colin-API in LEAR is called to provide this data.

For Expo companies, Head Office information is required instead of Records and Registered Office details. However, this information is currently missing from the Colin-API service. Code changes are needed in both Colin-API and Namex-API to address this issue.

please reference to #24319

For example (currently in PROD), the head office should be retrieved for xpro company as:
image.png

While, in TEST, the new changes doesn't include headoffice info:
image.png

@eve-git eve-git added the Names Team Name Request Name Examination Team label Nov 20, 2024
@ozamani9gh
Copy link
Collaborator

@ozamani9gh has to determine how to replace NAMEX COLIN-API functionality with LEAR COLIN-API functionality.

@ozamani9gh
Copy link
Collaborator

@eve-git spoke to Kathryn and Jeff about this ticket. This is not a showstopper for NRO Decommission. i still think we should fix it. During grooming hopefully we can work with @vysakh-menon-aot to determine when LEAR COLIN-API changes will be ready in DEV, TEST and PROD.

@eve-git eve-git self-assigned this Nov 28, 2024
@eve-git eve-git changed the title Namex: missing headoffice info for expo-companies Namex: missing headoffice info for xpro-companies Nov 28, 2024
@eve-git
Copy link
Collaborator Author

eve-git commented Nov 29, 2024

The code changes applied to both LEAR/COLIN_API and NAMEX
bcgov/lear#3102
bcgov/namex#1620

@eve-git
Copy link
Collaborator Author

eve-git commented Dec 4, 2024

ready to test in TEST and DEV environment

@gunanagar
Copy link
Collaborator

@eve-git - In test i am still seeing blank
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Names Team Name Request Name Examination Team
Projects
None yet
Development

No branches or pull requests

3 participants