Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's better if TranslatableAdmin changes the admin form in place, so that there is no need for TranslationInlines. #52

Open
bbmokhtari opened this issue Nov 10, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bbmokhtari
Copy link
Owner

bbmokhtari commented Nov 10, 2018

Is your feature request related to a problem? Please describe.
Currently the way to manage the translations in the admin is to inherit the admin from TranslatableAdmin and add TranslationInline as its inline.
It's better if TranslatableAdmin changes the admin form in place, so that there is no need for TranslationInlines.

Describe the solution you'd like
Each translatable field should be duplicated in the admin form for each supported language. so if name is a translatable field, there should be name (en - default), name (de), etc. for all the languages. If the field is required (blank=False) the default language field should be required as well, but not other language fields.
This way the admin inlines can manage translations as well and they are not restricted because of the inline limit issues in Django.

@bbmokhtari bbmokhtari added the enhancement New feature or request label Nov 10, 2018
@bbmokhtari bbmokhtari self-assigned this Nov 10, 2018
@fabiocaccamo
Copy link

Frankly I love how django-modeltranslation customizes the admin using jquery tabs, I think that it's the best solution. Is it planned to do something similar?

@bbmokhtari
Copy link
Owner Author

Hey there. First of all thanks for being honest. Second, no, it just means adding new fields next to the translatable fields for other languages than the default one. Although I like your proposition and I'll consider it.
Also let me be honest with you too. This update will be a major update in semantic versioning (2.0.0). It will need a lot of change and may not be released until a couple of months. So if you're looking to use a library right now I'd recommend you using whatever you think is best (django-modeltranslation is very mature.)
Any way I wish you good luck mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants