Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

total_grains from get_mash_info() includes non-mashed ingredients #1

Open
kschluns opened this issue Jan 19, 2020 · 0 comments
Open

Comments

@kschluns
Copy link

In the get_mash_info() function, total_grains = calc_percent_of_total().

calc_percent_of_total() returns the total weight of all fermentable ingredients instead of only the mashed ingredients. This creates an issue for beers like the Belgian Tripel where we use 2 lbs of candi syrup and those 2 lbs are not part of the mash bill. Therefore all the water and chemistry estimates shouldn't include those 2 lbs in their calculations. This is incorrectly inflating the water bill (not by a huge amount... ~0.25 gallons).

The solution is to have calc_percent_of_total() only return ingredients used in the mash. In the EZ Brew Spreadsheet, they track for each fermentable ingredient whether it is a mash ingredient or non-mash ingredient. We also need to do something similar on the DB-side where we track that for each grain and then account for it in the calc_percent_of_total() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant