Using consistent color for common part of completion?

[BooAA]

Hi,

I was trying to add support for corfu and found that the colors to highlight the common part of completions are different among packages. Below are the three I can tell:

1. company

`(company-tooltip-common ((t (:foreground ,zenburn-green+2))))

2. built-in completion

`(completions-common-part ((t (:foreground ,zenburn-blue))))

3. corfu, which has no defface to configure but it directly use the results returned by the built-in system, so the result is the same as 2.

I'm not sure if using same color for all 3 cases is a good idea (since I'm quite used to the current color for built-in completion), but I think company and corfu should use the same color as both of them provide same kind of UI. Unfortunately, corfu current does not provide defface to configure the color, I think we have 2 path to go:

1. Ask corfu's author if we can have additional defface variable to customize the color instead of rely on the default output.
2. Use same color for all 3 cases for better consistency. (if that would be the case, I will propose to use the color of company for all 3 cases as it's the most popular one and has most users.)

What do you think?

[bbatsov]

Let's go with 2) as the easiest option, although this doesn't stop you from asking corfu's author for the extra face that can be added down the road.