go-guru-hl-identifier-face is barely visible

[sdevlin]

go-guru-hl-identifier-face is used by the go-guru package to highlight occurrences of the symbol under point. It simply inherits the highlight face, which is quite subtle in zenburn.

I'm not sure whether it's right for zenburn or the go-guru package to fix this, but I did notice that zenburn already includes a lot of faces specific to third-party packages.

I think this may be related to #269.

[basil-conto]

The go-guru package can't do much more than inheriting from standard faces. It is up to zenburn to adapt as many 3rd-party packages to its palette as possible, especially when "conflicts" like this arise.

Given the zenburn author's preference to keep the highlight face as subtle as possible, the de-facto solution to this issue is to customise the go-guru-hl-identifier-face under zenburn. You can look through some of the merged PRs here for inspiration, should you decide to fix this yourself.