Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macos_bundle with ios base_sdk #1081

Open
ajanuar opened this issue Feb 18, 2021 · 5 comments · May be fixed by #2318
Open

macos_bundle with ios base_sdk #1081

ajanuar opened this issue Feb 18, 2021 · 5 comments · May be fixed by #2318

Comments

@ajanuar
Copy link

ajanuar commented Feb 18, 2021

Is it possible to have macos_bundle with base SDK iOS?

EarlGrey 2.0 integration requires to create macos bundle with base sdk iOS.
@brentleyjones
Copy link
Collaborator

Yes. Here is an incomplete (no tests) and bit-rotted commit that adds it: 558ea6a

I would review and help shepherd something in, if a PR was opened.

@ajanuar
Copy link
Author

ajanuar commented Feb 19, 2021

Hi @brentleyjones, I will take a look. thanks!

@ajanuar
Copy link
Author

ajanuar commented Feb 19, 2021

Hi @brentleyjones, I found difficulties to merge your branch to upstream. Can you guide me? Thanks

https://github.com/ajanuar/rules_apple/blob/02606992cc6b1cf85f810500220363b7fba6a77f/apple/internal/partials/framework_import.bzl#L197

vs

rules_apple/apple/internal/partials/framework_import.bzl

Line 190 in 558ea6a

executable = rule_executables._imported_dynamic_framework_processor,

@brentleyjones
Copy link
Collaborator

There has been some refactoring. I'll take a stab at getting it back to the same (no-test) state today.

@brentleyjones brentleyjones mentioned this issue Feb 22, 2021
Closed
@brentleyjones
Copy link
Collaborator

#1085

@kennethvl kennethvl linked a pull request Nov 3, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ios_bundle rule kennethvl/rules_apple
Add ios_bundle rule bazelbuild/rules_apple
2 participants
@brentleyjones @ajanuar