You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the way that the native version of android_ndk_repository structured / symlinked the NDK into bazel's external repository directory, the way to include things like cpu-features was
However this presents a migration issue for projects that use the native version of the rule, so a workaround was introduced to allow including the headers with the ndk/ prefix (by adding another symlink that results in the previous include path). We should migrate projects and remove this workaround.
The text was updated successfully, but these errors were encountered:
IMO, better to go a step further and migrate people to https://github.com/google/cpu_features. The only reason the NDK still ships its own is because we don't want to break existing builds that depend on it. If someone needs to put in effort to migrate, they might as well migrate to the new thing that's actually maintained (there's even an interface that's compatible with the old NDK one for use as a drop-in replacement: https://github.com/google/cpu_features/tree/main/ndk_compat)
I wasn't aware of the separate cpu_features project -- I'll add a note about this!
For now, some users are blocked from moving to the starlark version of android_ndk_repository because other projects aren't migrated to either https://github.com/google/cpu_features or non-ndk/-prefixed include paths (this is all pretty new so they're probably not even aware, and I'm sure we'll uncover other migration issues).
With the way that the native version of
android_ndk_repository
structured / symlinked the NDK into bazel's external repository directory, the way to include things like cpu-features wasWith the way the Starlark version of
android_ndk_repository
structures the NDK symlinks, thendk/
prefix is not needed:However this presents a migration issue for projects that use the native version of the rule, so a workaround was introduced to allow including the headers with the
ndk/
prefix (by adding another symlink that results in the previous include path). We should migrate projects and remove this workaround.The text was updated successfully, but these errors were encountered: