Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add history entries for tars attribute #654

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

thesayyn
Copy link
Collaborator

@thesayyn thesayyn commented Jul 18, 2024

image-spec says that this field is optional, however some systems like seen in #645 require this field. Also, skipping history entries lead to broken images if the base image already had one.

fixes #645

@thesayyn thesayyn changed the base branch from main to 2.x July 18, 2024 12:16
@thesayyn
Copy link
Collaborator Author

This partially fixes #438 too.

@thesayyn thesayyn force-pushed the add_history_entries branch 2 times, most recently from ad5d50d to e422780 Compare July 18, 2024 14:35
@thesayyn thesayyn requested a review from alexeagle July 18, 2024 14:36
@thesayyn thesayyn force-pushed the add_history_entries branch from e422780 to ee081b5 Compare July 25, 2024 17:37
@thesayyn thesayyn merged commit 94be214 into 2.x Jul 25, 2024
18 checks passed
@thesayyn thesayyn deleted the add_history_entries branch July 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0beta1: regression: cmd inherited from base image should be cleared when setting entrypoint
2 participants