Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename oci_tarball to oci_load #636

Merged
merged 1 commit into from
Jun 24, 2024
Merged

refactor: rename oci_tarball to oci_load #636

merged 1 commit into from
Jun 24, 2024

Conversation

alexeagle
Copy link
Collaborator

The primary use is with 'bazel run' to load the image into the container daemon. Producing a tarball is an optional side-effect and not recommended for most use cases. The new name makes this more clear.

@alexeagle alexeagle requested a review from thesayyn June 24, 2024 13:12
The primary use is with 'bazel run' to load the image into the container daemon.
Producing a tarball is an optional side-effect and not recommended for most use cases.
The new name makes this more clear.
Copy link
Collaborator

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe name could be oci_daemon_load to be explicit?

@alexeagle
Copy link
Collaborator Author

Decided over VC that this shorter name is good.

@alexeagle alexeagle merged commit fcdaf24 into 2.x Jun 24, 2024
18 checks passed
@alexeagle alexeagle deleted the rename_tarball branch June 24, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants