-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oci_pull supports loading Helm charts #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!!
Could you also try updating a documentation spot on oci_pull so it's easier for users to discover this ability?
Not going to merge this yet, as expanding the mime types is just the tip of an iceberg where we will get a larger scope and need to make a conscious choice about that. |
@alexeagle no worries. I will spend some time adding more documentation and test cases as well. I'm also having trouble coming up with a general use case for someone (besides me) who wants to use this functionality. Downloading the OCI helm chart is easy enough, but what to do with it afterwards? Any guidance you could give here would be appreciated. |
That's the rest of the iceberg, aka OCI artifacts, which we are not yet ready to support. Neither rules_oci nor crane is able to do anything with artifacts yet. On top of my head, I can think of using parts of a pulled helm chart to create a new one and push it with Currently, rules_oci only conforms to the non-artifact part of https://github.com/opencontainers/image-spec, but we are considering adding full support for artifacts in the future. |
I want this, fwiw! I have my own bazel code that can do |
I don't think we can accept this now, as the whole story for OCI artifacts is missing here. We need to work on #282 first before we can add this. |
This MR shows an example of loading a Helm chart using
oci_pull
from a repository (for example, ECR)For example, in
WORKSPACE
:This is related to issue #282