Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using oci_image_index doesn't produce a .digest target while oci_image does #735

Open
mislavmandaricaxilis opened this issue Nov 13, 2024 · 2 comments

Comments

@mislavmandaricaxilis
Copy link
Contributor

After #346 got merged, using oci_image macro also produces a .digest target, which contains a digest of the image.

But this was not done for oci_image_index, so switching to a multi-arch images causes a regression in experience because .digest target is missing.

Same as with oci_image, it's easy to write it ourselves, but having it in rules_oci directly makes it easy and consistent.

I'm willing to contribute a PR myself for this change if maintainers agree with the suggestion.

@thesayyn
Copy link
Collaborator

thesayyn commented Dec 5, 2024

This is a reasonable request, PRs are welcome.

@mislavmandaricaxilis
Copy link
Contributor Author

Here's the PR for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants