fix: Support loading tarballs with older podman #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a breaking change unfortunately. It changes invocation of the underlying binary from |
|
@thesayyn, thanks for looking into this and you feedback. I wasn't aware that this was a breaking change under Docker; my understanding was that docker supports the same Can you suggest an alternate approach I could investigate that would be compatible? |
|
It's a breaking change for rules_oci to change how we invoke the loader cli, it could podman or docker or some shell script user wrote. If we change it from |
Older versions of Podman appear to handle loading a tarball differently
depending upon with the input is /dev/stdin or not. In particular:
podman load --input <(cat foo.tar)
raises an error, while:
cat foo.tar | podman load
works without error. (Podman loads from stdin if no --input is specified.)
This enables support for podman v3.4.4 included in Ubuntu 22.04.
fixes bazel-contrib#711
nholstein
force-pushed
the
oci_load-with-old-podman
branch
from
ff4c4d1 to
8e40c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of Podman appear to handle loading a tarball differently depending upon with the input is /dev/stdin or not. In particular:
raises an error, while:
works without error. (Podman loads from stdin if no --input is specified.)
This enables support for podman v3.4.4 included in Ubuntu 22.04.
fixes #711