Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules_oci compatibility_level for 2.0.0 was left un-incremented #703

Open
mjcarroll opened this issue Sep 24, 2024 · 1 comment
Open

rules_oci compatibility_level for 2.0.0 was left un-incremented #703

mjcarroll opened this issue Sep 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mjcarroll
Copy link

I have a project that specifies in the root MODULE.bazel file:

bazel_dep(name = "rules_oci", version = "1.8.0")

And then in a transitive dependency

bazel_dep(name = "rules_oci", version = "2.0.0")

Because of this, the build continues by resolving the dependency version to "2.0.0" and fails to build because of API changes between 1.8.0 and 2.0.0.

Based on my reading of https://bazel.build/external/module#version-selection, and specifically https://bazel.build/external/module#compatibility_level, the compatibility_level in this location: https://github.com/bazelbuild/bazel-central-registry/blob/f29aeac836566a898885b18fa32a40018501a045/modules/rules_oci/2.0.0/MODULE.bazel#L6 should have been incremented to "2" to reflect the major version with semver.

@thesayyn
Copy link
Collaborator

Interesting, i thought bzlmod would select the minimum version. Am i missing something?

@thesayyn thesayyn added the bug Something isn't working label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants