From c2d612da3a6c3805e408936137ff31d1ee2f8e6d Mon Sep 17 00:00:00 2001 From: Farid Zakaria Date: Tue, 18 Jun 2024 14:43:06 -0700 Subject: [PATCH] Remove format type --- java/private/checkstyle.bzl | 7 ------- 1 file changed, 7 deletions(-) diff --git a/java/private/checkstyle.bzl b/java/private/checkstyle.bzl index a72191f1..2c4b0db6 100644 --- a/java/private/checkstyle.bzl +++ b/java/private/checkstyle.bzl @@ -9,7 +9,6 @@ Checkstyle rule implementation def _checkstyle_impl(ctx): info = ctx.attr.config[CheckStyleInfo] config = info.config_file - output_format = info.output_format config_dir = paths.dirname(config.short_path) maybe_cd_config_dir = ["cd {}".format(config_dir)] if config_dir else [] @@ -22,7 +21,6 @@ def _checkstyle_impl(ctx): ] + maybe_cd_config_dir + [ "$OLDPWD/{lib} -o checkstyle.xml -f xml -c {config} {srcs}".format( lib = info.checkstyle.short_path, - output_format = output_format, config = config.basename, srcs = " ".join(["$OLDPWD/" + f.short_path for f in ctx.files.srcs]), ), @@ -73,11 +71,6 @@ _checkstyle_test = rule( [CheckStyleInfo], ], ), - "output_format": attr.string( - doc = "Output Format can be plain or xml. Defaults to plain", - values = ["plain", "xml"], - default = "plain", - ), "xslt": attr.label( doc = "Path to the checkstyle2junit.xslt file", allow_single_file = True,