Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild libsndfile_arm64.dylib with latest FLAC #31

Open
bemoody opened this issue Jul 10, 2024 · 3 comments
Open

Rebuild libsndfile_arm64.dylib with latest FLAC #31

bemoody opened this issue Jul 10, 2024 · 3 comments

Comments

@bemoody
Copy link

bemoody commented Jul 10, 2024

It appears that the current libsndfile_arm64.dylib in this repository was built using libFLAC 1.4.2, whereas all of the other binaries here were built using libFLAC 1.4.3.

libFLAC 1.4.2 has at least one bug (failing to seek to a certain time point) that appears to be fixed in 1.4.3.

Could you please rebuild libsndfile_arm64.dylib using the latest FLAC?

@bastibe
Copy link
Owner

bastibe commented Jul 15, 2024

Thank you for the bug report. To help me, you can edit the two build scripts with current versions of the dependency libraries, and provide the changes as a pull request.

@bemoody
Copy link
Author

bemoody commented Jul 15, 2024

To be clear, in linux_build.sh and mac_build.sh the versions are listed as follows:

OGGVERSION=1.3.5
VORBISVERSION=1.3.7
FLACVERSION=1.4.3
OPUSVERSION=1.4
MPG123VERSION=1.32.3
LAMEVERSION=3.100
SNDFILE_VERSION=1.2.2

So both of these scripts are already pointing to the latest version of FLAC. (However, by running strings on the binary files, I can see that libsndfile_arm64.dylib was built using FLAC 1.4.2, whereas the other five were using FLAC 1.4.3.)

That said, I'll make a pull request to bump the version numbers for opus and mpg123 if that will be helpful.

@bastibe
Copy link
Owner

bastibe commented Jul 16, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants